Commit cc24bd19 authored by Kochunas, Brendan M.'s avatar Kochunas, Brendan M. Committed by Henderson, Shane
Browse files

Fixes warnings for non-existent includes

Squash branch 'fix_missing_includes_from_trilinos' into 'master'

* Fixes warnings for non-existent includes

Description:
The bad include statements were coming from the TrilinoSS package
which is Trilinos's package for SuiteSparse. Pretty sure we do
not need this. By disabling this package, no more missing includes
warnings when compiling the Fortran files in Futility.

When building Futility with Trilinos there would be endless compiler warnings when compiling Futility and Futility dependent packages (i.e. MPACT) for missing include directories. Typically something like:
```
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/AMD/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/COLAMD/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/UFconfig/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/KLU/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/BTF/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/CAMD/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/Trilinos/packages/amesos/src/SuiteSparse/CCOLAMD/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/common/auxiliarySoftware/SuiteSparse/src/AMD/Include' [-Wmissing-include-dirs]
f951: Warning: Nonexistent include directory '.../Futility/common/auxiliarySoftware/SuiteSparse/src/UFconfig/Include' [-Wmissing-include-dirs]
```

This branch adds a hard disable for 1 Trilinos package, `TrilinosSS`, for configuring Trilinos's copy SparseSuite in Futility's configuration. Presumably SparseSuite is needed for testing other packages in Trilinos. I'm not sure that we need it.

No corresponding VERA-dev issue. This is just a bit of Futility house-keeping

**Developer Checklist:**
- [x] Have you done a self-review after creating the merge request?
- [x] Have you filled in the Merge Request information (title, description) thoroughly?
- [x] Have you updated the relevant tickets (if this MR is linked to any VERA-dev tickets)? Small change that only affects compiler warnings, does not effect functionality of Futility or Futility dependent packages.
- [ ] Have you addressed all suggested feedback and commented on it to let the reviewer know? (Do not resolve discussions that the reviewer started)

**Reviewer Checklist:**
- [ ] Have you confirmed all discussions were adequately addressed and resolved them all?
- [x] Does it conform to formatting guidelines? Yes
- [x] Are there adequate and clear comments? Yes
- [x] Is the design clean and sensible? Yes
- [x] Are the changes optimal/efficient? One line change
- [x] Were sufficient DBC checks added? Only modified cmake build system
- [x] Are there unit tests? (if necessary) No unit tests necessary
- [ ] Is the MR description clear, including a link to the VERA-Dev issue if appropriate?

**PSM Checklist**
- [ ] Have you confirmed that all discussions were addressed, or that follow-on issues have been created for them?
- [x] Have you confirmed sufficient testing was conducted? Yes
- [x] Does this impact other repositories? NO
- [x] Does the MR have an adequate description?
- [x] If the MR has multiple commits, did you set the MR to squash merge? One commit

See merge request https://code.ornl.gov/futility/Futility/-/merge_requests/414
parent 8f6c02e3
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ SET(${PROJECT_NAME}_ENABLE_CXX11_DEFAULT ON)
IF (NOT ${PROJECT_NAME}_EXCLUDE_PACKAGES)
  SET(${PROJECT_NAME}_EXCLUDE_PACKAGES
    # Trilinos disables
    TrilinosSS
    ML
    Gtest
    Sacado