GitLab

(cherry picked from commit f2439b95)

Kitware Robot authored Sep 26, 2017 and Maynard, Robert committed Oct 04, 2017

Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
wrap =delete;

Kitware Robot authored Sep 25, 2017 and Maynard, Robert committed Oct 02, 2017

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

This is a fix for:
https://gitlab.kitware.com/vtk/vtk/issues/14310

Windows applications that run for a long time report that rendered
objects do not change. This is because the modified time on a Windows
system is 32 bits. This causes overflows that defeat the modified time
mechanism. This patch defines a new type, vtkMTimeType that is 64
unsigned integer regardless of the architecture.

A mechanism to provide backward compatibility is introduced. The
preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications
that must build against VTK versions that use the "unsigned long" type
for MTime's.

Methodology used to find MTime occurences:
1) Identify files as follows:
   git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
2) Hand edit each of those files replacing "unsigned long" with
   "vtkMTimeType" where appropriate.
3) Temporarily change typedef for vtkMTimeType to "double" to detect
   missing conversions

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

Proj Upstream authored Mar 08, 2016 and Lipsa, Dan committed Mar 08, 2016

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

Change-Id: I86bfb1f0a251d14a14e5b4761e4c3c387c2bbc38

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Include the module-wide header from every header in each module.
Reference the export/visibility macro for the module.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

The CVS $Revision$ keyword replacement will no longer maintain these
macros automatically.  They were used only to implement CollectRevisions
and vtkObjectBase::PrintRevisions, an API that was never used.

Automated as follows:

  pass 0:
  catch templates
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'

  pass 1:
  main changes
  ---------------
  $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
    echo "$file" 1>&2
    perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
  done
  $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
    echo "$file" 1>&2
    perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
  done

  pass 2:
  verify
  ---------------
  $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'

Fixed multi-line vtkCxxRevisionMacro and templates by hand.

vtkIncrementalOctreePointLocator,
vtkIncrementalOctreeNode,
and TestIncrementalOctreePointLocator.
Updated are vtkCell-derived classes and those VTK
classes with Setlocator().

Removed SelectInputScalars/Vectors... from the public interface as part of the VTK 4.2 release process.

1.) vtkTypeRevisionMacro is now used in all VTK classes in place of
    vtkTypeMacro.  It invokes the original vtkTypeMacro and then adds
    a protected CollectRevisions method for future use in serialization.
    A corresponding vtkCxxRevisionMacro has been added to every .cxx file
    to implement the CollectRevisions method for each class.  This will
    allow collection of every class revision at run time.  Any new VTK class
    should use vtkTypeRevisionMacro instead of vtkTypeMacro.  The .cxx
    implementation should then have the following line:
      vtkCxxRevisionMacro(vtkFoo, "$Revision: 1.1 $");
    CVS should insert the correct revision number when the class is commited.

2.) vtkTypeMacro now also adds a typedef called "Superclass" to refer to
    the superclass of any VTK class.  All PrintSelf methods have been
    updated to call their superclass's PrintSelf like this:
      this->Superclass::PrintSelf(os,indent);
    This should reduce the number of places that refer to a superclass
    by its actual name.

3.) The standard ::New() method implementation has been replaced with a
    macro.  Instead of an explicitly written implementation to try the
    object factory and then call the new operator, VTK classes should
    instead use the following macro unless they have a special New() method:
      vtkStandardNewMacro(vtkFoo);
    This will implement the New() method in the standard way.  The line
    should appear in the .cxx implementation file, not in the header.
    Using the macro will make it easier to change the standard
    implementation of the method.

Also removed tabs from many files.

ENH: All unimplemented copy constructors and assignment operators made private so that errors will show up at compile time instead of link time.  Since they are not implemented, they can never be called, so they should be private instead of protected.