This project is mirrored from https://gitlab.kitware.com/vtk/vtk-m.git. Pull mirroring updated .
  1. 13 Dec, 2017 2 commits
  2. 22 Nov, 2017 1 commit
    • Philippe Pébaÿ's avatar
      Fixed issues with the computation of material interfaces in HTG · a4cc7836
      Philippe Pébaÿ authored
      This commit addresses to main issues:
      1. The AxisReflection was /adding/ modified arrays, as opposed to
         modifying in situ the interface arrays (vectors and intercepts).
         This had initially made on purpose with the intent of temporary
         retaining the original arrays for debugging purposes. However,
         this had been forgotten and left in place. As a result, interface
         computations after a reflection where incorrect. This bug was
         not revealing itself in the test harness so far as this combination
         (reflection + interface computations) was not exercised.
         As a result, this commit addresses the issue but also verifies
         this combination. Furthermore, the HTG source was modified in
         order to allow for the specification of intercepts arrays in
         the form that exercise this configuration.
      2. The Geometry extraction was not building material interfaces, as
         a result of some code having been leftover during the HTG-v2
         merger in VTK 8. This commit fixes this issue, and also adds
         a unit test to verify material extraction together with its
         corresponding non-regression image.
      a4cc7836
  3. 07 Nov, 2017 1 commit
  4. 06 Nov, 2017 2 commits
  5. 02 Nov, 2017 4 commits
  6. 01 Nov, 2017 1 commit
  7. 31 Oct, 2017 4 commits
  8. 29 Oct, 2017 1 commit
    • Philippe P. Pébaÿ's avatar
      Fixed a bug in the Moore supercursor · baef249b
      Philippe P. Pébaÿ authored
      The goal of this commit was to fix a bug that occurred only in
      the (f=2;d=3) case ("binary 3D"), and that had been caused
      by a typo in the MooreChildCursorToChildTable and
       MooreChildCursorToParentCursorTable tables: specifically,
      a "23" had been written instread of "32".
      
      In addition, two non-regression tests, as well as their baseline
      images, were added in order to validate this fix:
      (i) a geometry case which does not exercise the offending part of
      the code but that illustrates the case built to do it; and
      (ii) a contouring case that does exercise that part of the code,
      for it relies on the "32" section of the Moore supercursor tables.
      baef249b
  9. 26 Oct, 2017 1 commit
  10. 24 Oct, 2017 2 commits
  11. 20 Oct, 2017 1 commit
  12. 16 Oct, 2017 1 commit
    • Sean McBride's avatar
      Fixed numerous warnings from the new cppcheck 1.81 · 442381f5
      Sean McBride authored
      Specifically:
      
      very strange braces!
      syntaxError,Common/DataModel/vtkHyperTreeGrid.cxx:699,error,syntax error
      
      changed size()>0 to !empty()
      stlSize,Filters/General/vtkLoopBooleanPolyDataFilter.cxx:1426,performance,Possible inefficient checking for 'nocellregion' emptiness.
      
      This useless flag has been there since code was added in 2000 in f50b0909
      knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:323,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:415,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:788,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:879,style,Condition 'flag' is always true
      
      This useless 'result' has been there since code was added in 2003 in dd39b9e4
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:236,style,Condition 'result' is always true
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:245,style,Condition 'result' is always true
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:254,style,Condition 'result' is always true
      
      New check in cppcheck 1.81, block is indeed dead code:
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:272,warning,Opposite inner 'if' condition leads to a dead code block.
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:293,warning,Opposite inner 'if' condition leads to a dead code block.
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:349,warning,Opposite inner 'if' condition leads to a dead code block.
      
      false positive, suppressed with zero initialization:
      uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:810,error,Uninitialized variable: curDistance
      uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:812,error,Uninitialized variable: curDistance
      
      free(NULL) is allowed, so just remove null check
      knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:920,style,Condition 'truthIds' is always false
      knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:956,style,Condition 'diskFile' is always false
      
      Simplified the calculation, verified same codegen on x86_64 with godbolt
      shiftTooManyBitsSigned,Rendering/Volume/vtkHAVSVolumeMapper.cxx:53,error,Shifting signed 32-bit value by 31 bits is undefined behaviour
      
      These have all been thus since their inception, but a global search find the same pattern in TestDijkstraGraphGeodesicPath.cxx, from which I copied the apparent solution
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:119,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:199,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:244,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:325,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:117,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:189,style,Condition 'distanceOffsetSpecified' is always false
      
      Toggle with #if instead
      knownConditionTrueFalse,Imaging/Hybrid/vtkSurfaceReconstructionFilter.cxx:300,style,Condition 'orientationPropagation' is always true
      
      Added parens
      clarifyCalculation,Common/DataModel/vtkLagrangeWedge.cxx:906,style,Clarify calculation precedence for '/' and '?'.
      442381f5
  13. 14 Oct, 2017 1 commit
    • David Thompson's avatar
      Fix some dashboard issues. · 1b0571a5
      David Thompson authored
      + Skip tests where the render window is generating images the wrong size.
      + Use stupid parentheses to make cppcheck happy.
      1b0571a5
  14. 12 Oct, 2017 2 commits
  15. 11 Oct, 2017 4 commits
  16. 10 Oct, 2017 1 commit
  17. 06 Oct, 2017 1 commit
  18. 05 Oct, 2017 1 commit
  19. 04 Oct, 2017 8 commits
  20. 03 Oct, 2017 1 commit
    • Corona, Thomas Joseph's avatar
      vtkPolygon: Add unbiased ear cut and bounded triangulate methods. · 05f3281e
      Corona, Thomas Joseph authored
      vtkPolygon's EarCutTriangulation() method uses a priority queue to
      determine the order in which polygon vertices are clipped. This
      results in a reproducible triangulation that is orientation-free, but
      only allows for a single triangulation for a polygon. Since
      ear-cutting is a heuristic, there is no guarantee that the result from
      EarCutTriangulation() is the best (or even acceptable).
      
      UnbiasedEarCutTriangulation() is an ear cutting method that removes
      the use of a priority queue, and instead allows the caller to seed the
      method's start point with a value.
      
      With the ability to triangulate a polygon in multiple ways,
      BoundedTriangulate() accepts a tolerance value that restricts the
      ratio of the area of the smallest triangle to the area of the
      polygon. The method returns the first triangulation that satisfies
      this criterion.
      05f3281e