Change-Id: Ic26d7e908ffbf37206b7642707f36471dbc97d62

Change-Id: Iba476de06c3c39ada4308a8960e10367296dede9

Change-Id: I479a708b60328c802578541d4386a0776785a1c2

Change-Id: Iac504211c41ce60fe9eef7e2d4bc6ad6022d6485

41d142e5 COMP: Fix compare sign warning in Ensight6BinaryReader.

Change-Id: I22d0d489188d72cf1abc0252b4082fd60679e257

8e9c51d7 Reverted some recent changes to detect isnan()

40fe9ec0 Replace the power-of-two scaling with a clearer implementation.
41e61435 Rewrite the PrepareImageData methods to check extents, not dims.

For some reason, checking in math.h ends up causing
compile failures on some Macs.

Change-Id: I454c91bd49f26018c862717edd00391a03f28996

fb8c7848 Fixed (undefined) use of null object.
6ffd3241 Fixed (undefined) use of null object.

Changed a probable typo from: newLines to newPolys

Caught by clang's ubsan.

Change-Id: I9a4a2aefb2d118d23bd0adb54a3332abc1eb500e

Added test against null, which was already being done
in the 'enabling' branch.

Caught by clang's ubsan.

Change-Id: I6ecb400103020b54dda18bd7062f43ba82854ac3

ed8e013e Fixed isnan compile error on some platforms

Add #include <math.h> to find C99 functions.
Thanks to David Gobbi.

Change-Id: Ia88708ab43fa5b4f26801449bbd910013077868f

8a045b49 Module macros cleanup.

Projects sometimes want to add modules directly i.e. have the vtk_module(..) and
vtk_module_library(..) calls directly added in the same CMakeLists.txt file
without using a module.cmake at all. This is needed especially for modules that
tend to depend on "all enabled" modules. This change ensures that
vtkModuleMacros work even when module.cmake is missing.

Change-Id: I11122a330cb31b3f8785435fddd44d44df9bd236

38f76b82 Eliminated (undefined) negation of INT_MIN
07cd3906 Changed computations to uint64 to prevent signed overflow
743dc8aa Initialize ivars to 0 to prevent access of uninitialized data
e29cc816 Eliminated (undefined) signed integer overflow

014c51a2 Fixed use of null object.

Identified by clang -fsanitize=null, it was a
copy-pasto newLines->newPolys.  Thanks to David Gobbi
and David Cole for pointing the correct solution.

Change-Id: I10efa32d3f6c96c00f54af42779f37fe4aa9326f

70c43542 COMP: Fix the vtkJPEGReader setjmp clobber warning.

With -Wclobbered, gcc produced the following for vtkJPEGReader.cxx:
warning: variable ‘fp’ might be clobbered by ‘longjmp’ or ‘vfork’.
The problem was that setjmp cannot restore all variables, so 'fp'
in particular should be stored in the setjmp data struct.

Change-Id: I54eb886585f21b69a65aeaebbaa5ae22983c8ec1

79feb9dd Reduce TestProjectedHexahedra window size to 500x500.

clang ubsan warned running vtkRenderingAnnotationCxx-TestCubeAxes2DMode:

Rendering/Annotation/vtkCubeAxesActor.cxx:1315:30: runtime error: negation of -2147483648 cannot be represented in type 'int'

This happens when 'range' is exactly 0.0, and so log10() gives -infinity,
which when cast to int (apparently) becomes INT_MIN which cannot
be negated due to the asymmetry of two's compliment representation.

Now, check log10() result with newly-created vtkMath::IsFinite API.
If the result is not finite, return 0 from vtkCubeAxesActor::Digits(),
which I'm not sure is the correct thing to return.

Change-Id: I36fc832df98ccb96c1fdc951c42e7e2c6de9d4b4

With clang's -fsanitize=signed-integer-overflow, the test
'vtkFiltersGeneralCxx-TestYoungsMaterialInterface' gives:

IO/Geometry/vtkAVSucdReader.cxx:302:34: runtime error: signed integer overflow: 16 * 504823808 cannot be represented in type 'int'
IO/Geometry/vtkAVSucdReader.cxx:302:60: runtime error: signed integer overflow: 4 * 2019295232 cannot be represented in type 'int'
IO/Geometry/vtkAVSucdReader.cxx:303:35: runtime error: signed integer overflow: 12 * -1340538880 cannot be represented in type 'int'
IO/Geometry/vtkAVSucdReader.cxx:313:35: runtime error: signed integer overflow: 369098752 * 2019295248 cannot be represented in type 'int'

This code tries to guess endianness, and when it's wrong it
ends up multiplying large numbers, resulting in signed overflow.
Fix is to do computations as uint64, which may still overflow,
but at least unsigned overflow is defined to wrap.

Did other misc cleanup too. Notably, the code could go into an
infinite loop trying big then little endianness over and over
again if a file is corrupt.

Change-Id: I2b7d84dae275386dcd87fa496b7916945284bc30

With -fsanitize=signed-integer-overflow, the test
'vtkIOXMLPython-TestEmptyXML' gives:

IO/XML/vtkXMLPStructuredDataReader.cxx:62:35: runtime error: signed integer overflow: 591396864 * -536868871 cannot be represented in type 'int'

The reason being that 'PointDimensions' was never set and so contained
random values that happened to be pretty big. There probably should
be some better error checking somewhere, but it seems a good
defence to zero these things anyway, in case a client of the class
(incorrectly) invokes a method that accesses the uninitialized data,
at least we'll get consistent results.

Change-Id: I77f5ac68d4edad632931667ddf5e87f930f48b3f

clang ubsan warned running some of the 'EnSightBlow' tests:

IO/EnSight/vtkEnSight6BinaryReader.cxx:2823:15: runtime error: signed integer overflow: -1358823424 * 4 cannot be represented in type 'int'

I just upcast to 64 bit so that the multiplication doesn't overflow.
The tests now pass with the ubsan check.

I have subtly changed the behaviour here, but believe the
intent is preserved.

Change-Id: I0a35789c169204f04d2a683a029e992e9b20ca65

9d80bf90 Increasing the bounds just a bit to avoid round-off issues.

eab902ac Adding in warning if the input vtkPointData structures is different.

This implementation is easier to read and performed using only integer
operations.

Change-Id: I97ea7e73e6bbaba14b7dc29d26e1db55e57136e4

The new rendering code using the extent coordinates to control where
drawing occurs. Simply checking the dimensions of the image is not
sufficient.

Change-Id: Ib8185affafdc345b760f6c2164584f8379982a13

The previous window size of 800x800 seemed needlessly large, and causes
test failures on screens with a height of 800 or less (e.g. some laptops).

Change-Id: Id6abd1bd773f0a074ebedb8eb0f699a7c8a665b5

96ae86c7 Reduce memory usage for TestCheckerboard

c250dadc COMP: Reduce memory usage for TestCheckerboard

This reduces the memory usage for TestCheckerboard.tcl by reducing the
Z extents of the images from 99 to 10. This reduces the memory usage
of the test from ~170MB to ~37MB.

Change-Id: I074012d39f017f03463c240e96635820c8abdbae

This reduces the memory usage for TestCheckerboard by reducing the
Z extents of the images from 99 to 10. This reduces the memory usage
of the test from ~170MB to ~37MB.

This should fix the test on AIX where it was running out of resources.

Change-Id: I3513406e35a88793eff96d36f07c8497e15401f4

aea5ff3d Fixed issue of using the wrong size for a vtkTypeInt64.

af106289 BUG: Vertext list leak

These filters use vtkDataSetAttributes to interpolate input
point data to the output polydata so we need to make sure
that the point data structures match on all processes and
data sets. If they don't, the filters now return an error
and fail.

Change-Id: I639964871d8cf9fdd398e821560050bedd937143

3dd5f751 Fix display attribute handling in vtkCompositePainter
82aee804 Only allow selection on visible blocks

vtkPLY allocates a list of vertices for each face. That list was not
freed after it was used in vtkPLYReader.

To further compilate things, vtkPLY::ascii_get_element and
vtkPLY::binary_get_element used two different forms of heap allocation.

Change-Id: Ic92d3b9dd3291576a8ce285e905db760cbf7f23b