Merge pull request #3139 from chuckatkins/update-third-party (d928a83a) · Commits · ecpcitest / ADIOS2

.github/workflows/everything.yml

+1 −1

Original line number	Diff line number	Diff line
		@@ -131,7 +131,7 @@ jobs:

		linux_emu:
		needs: [format, git_checks]
		if: needs.git_checks.outputs.num_code_changes > 0
		if: false # needs.git_checks.outputs.num_code_changes > 0

		runs-on: ubuntu-latest
		container:

+1 −1

Original line number	Diff line number	Diff line
		@@ -37,7 +37,7 @@ namespace helper

		bool CreateDirectory(const std::string &fullPath) noexcept
		{
		return adios2sys::SystemTools::MakeDirectory(fullPath);
		return static_cast<bool>(adios2sys::SystemTools::MakeDirectory(fullPath));
		}

		bool IsLittleEndian() noexcept

+6 −7

Original line number	Diff line number	Diff line
		@@ -64,13 +64,12 @@ else()
		add_subdirectory(pugixml)
		endif()
		adios2_add_thirdparty_target(pugixml pugixml)
		if(ADIOS2_USE_EXTERNAL_NLOHMANN_JSON)
		find_package(nlohmann_json REQUIRED)
		adios2_add_thirdparty_target(nlohmann_json nlohmann_json::nlohmann_json)
		else()

		# ADIOS uses a wrapper header for nlohmann_json to suppress noisy compiler
		# warnings
		add_subdirectory(nlohmann_json)
		adios2_add_thirdparty_target(nlohmann_json nlohmann_json)
		endif()
		adios2_add_thirdparty_target(nlohmann_json nlohmann_json_wrapper)

		if(ADIOS2_USE_EXTERNAL_YAMLCPP)
		find_package(yaml-cpp REQUIRED)
		else()

0 → 100644

+43 −0

Original line number	Diff line number	Diff line
		---
		name: Bug report
		about: Create a report to help us improve
		title: ''
		labels: 'bug'
		assignees: ''
		---

		Describe the bug

		Include a clear and concise description of what the problem is, including what
		you expected to happen, and what actually happened.

		Steps to reproduce the bug

		It's important that we are able to reproduce the problem that you are
		experiencing. Please provide all code and relevant steps to reproduce the
		problem, including your `BUILD`/`CMakeLists.txt` file and build commands. Links
		to a GitHub branch or [godbolt.org](https://godbolt.org/) that demonstrate the
		problem are also helpful.

		Does the bug persist in the most recent commit?

		We recommend using the latest commit in the master branch in your projects.

		What operating system and version are you using?

		If you are using a Linux distribution please include the name and version of the
		distribution as well.

		What compiler and version are you using?

		Please include the output of `gcc -v` or `clang -v`, or the equivalent for your
		compiler.

		What build system are you using?

		Please include the output of `bazel --version` or `cmake --version`, or the
		equivalent for your build system.

		Additional context

		Add any other context about the problem here.

0 → 100644

+24 −0

Original line number	Diff line number	Diff line
		---
		name: Feature request
		about: Propose a new feature
		title: ''
		labels: 'enhancement'
		assignees: ''
		---

		Does the feature exist in the most recent commit?

		We recommend using the latest commit from GitHub in your projects.

		Why do we need this feature?

		Ideally, explain why a combination of existing features cannot be used instead.

		Describe the proposal

		Include a detailed description of the feature, with usage examples.

		Is the feature specific to an operating system, compiler, or build system version?

		If it is, please specify which versions.