Commit e3a45a24 authored by David Tellenbach's avatar David Tellenbach
Browse files

[ARM][Thumb2InstrInfo] Fix default `0` opcode when rewriting frame indices 

The static functions `positiveOffsetOpcode`, `negativeOffsetOpcode` and
`immediateOffsetOpcode` (lib/Target/ARM/Thumb2InstrInfo.cpp) currently can
return `0` as default opcode which is meaningless in this situation.

This patch replaces this default value by llvm_unreachable.

Reviewers: t.p.northover, tellenbach

Reviewed By: tellenbach

Subscribers: tellenbach, kristof.beyls, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D69432

Patch By: Lorenzo Casalino <lorenzo.casalino93@gmail.com>
parent e59f7488

llvm/lib/Target/ARM/Thumb2InstrInfo.cpp

+3 −9
Original line number Diff line number Diff line
@@ -388,10 +388,8 @@ negativeOffsetOpcode(unsigned opcode) 
    return opcode;



  default:

    break;

    llvm_unreachable("unknown thumb2 opcode.");

  }



  return 0;

}



static unsigned
@@ -420,10 +418,8 @@ positiveOffsetOpcode(unsigned opcode) 
    return opcode;



  default:

    break;

    llvm_unreachable("unknown thumb2 opcode.");

  }



  return 0;

}



static unsigned
@@ -461,10 +457,8 @@ immediateOffsetOpcode(unsigned opcode) 
    return opcode;



  default:

    break;

    llvm_unreachable("unknown thumb2 opcode.");

  }



  return 0;

}



bool llvm::rewriteT2FrameIndex(MachineInstr &MI, unsigned FrameRegIdx,