Commit c7557dd6 authored by Francis Visoiu Mistrih's avatar Francis Visoiu Mistrih
Browse files

[Remarks] Remove references to ELF support 

There is no ELF support at the moment.

Remove all the references to the `.remarks` section.
parent 209d5a12

llvm/docs/CommandGuide/llc.rst

+2 −2
Original line number Diff line number Diff line
@@ -149,8 +149,8 @@ End-user Options 


.. option:: -remarks-section



 Emit the .remarks (ELF) / __remarks (MachO) section which contains metadata

 about remark diagnostics.

 Emit the __remarks (MachO) section which contains metadata about remark

 diagnostics.



Tuning/Configuration Options

~~~~~~~~~~~~~~~~~~~~~~~~~~~~

llvm/docs/Remarks.rst

+0 −1
Original line number Diff line number Diff line
@@ -592,7 +592,6 @@ This can be overridden by using the flag ``-remarks-section=<bool>``. 
The section is named:



* ``__LLVM,__remarks`` (MachO)

* ``.remarks`` (ELF)



C API

=====

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1380,7 +1380,7 @@ void AsmPrinter::emitRemarksSection(RemarkStreamer &RS) { 
               : RemarkSerializer.metaSerializer(OS);

  MetaSerializer->emit();



  // Switch to the right section: .remarks/__remarks.

  // Switch to the remarks section.

  MCSection *RemarksSection =

      OutContext.getObjectFileInfo()->getRemarksSection();

  OutStreamer->SwitchSection(RemarksSection);

llvm/lib/MC/MCObjectFileInfo.cpp

+0 −3
Original line number Diff line number Diff line
@@ -480,9 +480,6 @@ void MCObjectFileInfo::initELFMCObjectFileInfo(const Triple &T, bool Large) { 
      Ctx->getELFSection(".eh_frame", EHSectionType, EHSectionFlags);



  StackSizesSection = Ctx->getELFSection(".stack_sizes", ELF::SHT_PROGBITS, 0);



  RemarksSection =

      Ctx->getELFSection(".remarks", ELF::SHT_PROGBITS, ELF::SHF_EXCLUDE);

}



void MCObjectFileInfo::initCOFFMCObjectFileInfo(const Triple &T) {

llvm/test/CodeGen/X86/remarks-section.ll

+0 −6
Original line number Diff line number Diff line 
; RUN: llc < %s -mtriple=x86_64-linux -remarks-section -pass-remarks-output=%/t.yaml | FileCheck -DPATH=%/t.yaml %s

; RUN: llc < %s -mtriple=x86_64-darwin -remarks-section -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN -DPATH=%/t.yaml %s

; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=yaml-strtab -remarks-section -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-STRTAB -DPATH=%/t.yaml %s
@@ -8,11 +7,6 @@ 
; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=bitstream -remarks-section=false -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-OVERRIDE-BITSTREAM %s

; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=yaml -remarks-section=true -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-OVERRIDE-YAML %s



; CHECK-LABEL: func1:



; CHECK: .section .remarks,"e",@progbits

; CHECK-NEXT: .byte



; CHECK-DARWIN: .section __LLVM,__remarks,regular,debug

; CHECK-DARWIN-NEXT: .byte