Commit b0561b33 authored by Tyker's avatar Tyker
Browse files

[NFC] Refactor representation of materialized temporaries 

Summary:
this patch refactor representation of materialized temporaries to prevent an issue raised by rsmith in https://reviews.llvm.org/D63640#inline-612718

Reviewers: rsmith, martong, shafik

Reviewed By: rsmith

Subscribers: thakis, sammccall, ilya-biryukov, rnkovacs, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69360
parent dd471dbe

clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ AST_MATCHER_P(Stmt, IgnoringTemporaries, ast_matchers::internal::Matcher<Stmt>, 
  const Stmt *E = &Node;

  while (true) {

    if (const auto *MTE = dyn_cast<MaterializeTemporaryExpr>(E))

      E = MTE->getTemporary();

      E = MTE->getSubExpr();

    if (const auto *BTE = dyn_cast<CXXBindTemporaryExpr>(E))

      E = BTE->getSubExpr();

    if (const auto *ICE = dyn_cast<ImplicitCastExpr>(E))

clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ buildBindArguments(const MatchFinder::MatchResult &Result, const CallExpr *C) { 
    const Expr *E = C->getArg(I);

    BindArgument B;

    if (const auto *M = dyn_cast<MaterializeTemporaryExpr>(E)) {

      const auto *TE = M->GetTemporaryExpr();

      const auto *TE = M->getSubExpr();

      B.Kind = isa<CallExpr>(TE) ? BK_CallExpr : BK_Temporary;

    }

clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp

+1 −1
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ const Expr *digThroughConstructors(const Expr *E) { 
      return nullptr;

    E = ConstructExpr->getArg(0);

    if (const auto *Temp = dyn_cast<MaterializeTemporaryExpr>(E))

      E = Temp->GetTemporaryExpr();

      E = Temp->getSubExpr();

    return digThroughConstructors(E);

  }

  return E;

clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ void ImplicitConversionInLoopCheck::check( 
  // iterator returns a value instead of a reference, and the loop variable

  // is a reference. This situation is fine (it probably produces the same

  // code at the end).

  if (IsNonTrivialImplicitCast(Materialized->getTemporary()))

  if (IsNonTrivialImplicitCast(Materialized->getSubExpr()))

    ReportAndFix(Result.Context, VD, OperatorCall);

}

clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ void NonConstParameterCheck::markCanNotBeConst(const Expr *E, 
  } else if (const auto *Constr = dyn_cast<CXXConstructExpr>(E)) {

    for (const auto *Arg : Constr->arguments()) {

      if (const auto *M = dyn_cast<MaterializeTemporaryExpr>(Arg))

        markCanNotBeConst(cast<Expr>(M->getTemporary()), CanNotBeConst);

        markCanNotBeConst(cast<Expr>(M->getSubExpr()), CanNotBeConst);

    }

  } else if (const auto *ILE = dyn_cast<InitListExpr>(E)) {

    for (unsigned I = 0U; I < ILE->getNumInits(); ++I)