Commit 8f1caf51 authored by Jacques Pienaar's avatar Jacques Pienaar
Browse files

[mlir] Only generate default for uncovered cases 

Have to explicitly check if all cases are covered instead.
parent 4bb4f5b1

mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

+4 −0
Original line number Diff line number Diff line
@@ -323,6 +323,9 @@ static void emitAvailabilityQueryForIntEnum(const Record &enumDef, 
                    enumerant.getSymbol(), avail.getMergeInstanceType(),

                    avail.getMergeInstance());

    }

    // Only emit default if uncovered cases.

    if (classCasePair.getValue().size() < enumAttr.getAllCases().size())

      os << "  default: break;\n";

    os << "  }\n"

       << "  return llvm::None;\n"

       << "}\n";
@@ -367,6 +370,7 @@ static void emitAvailabilityQueryForBitEnum(const Record &enumDef, 
                    enumerant.getSymbol(), avail.getMergeInstanceType(),

                    avail.getMergeInstance());

    }

    os << "  default: break;\n";

    os << "  }\n"

       << "  return llvm::None;\n"

       << "}\n";