Commit 61c9de75 authored by Francis Visoiu Mistrih's avatar Francis Visoiu Mistrih
Browse files

[X86] Enable the MachineVerifier by default 

The machine verifier was disabled for x86 by default. There are now only
9 tests failing, compared to what previously was between 20 and 30.

This is a good opportunity to file bugs for all the remaining issues,
then explicitly disable the failing tests and enabling the machine
verifier by default.

This allows us to avoid adding new tests that break the verifier.

PR27481

llvm-svn: 345513
parent 905abe5b

llvm/lib/Target/X86/X86TargetMachine.h

+0 −4
Original line number Diff line number Diff line
@@ -53,10 +53,6 @@ public: 
  TargetLoweringObjectFile *getObjFileLowering() const override {

    return TLOF.get();

  }



  bool isMachineVerifierClean() const override {

    return false;

  }

};



} // end namespace llvm

llvm/test/CodeGen/X86/avx512-regcall-NoMask.ll

+4 −3
Original line number Diff line number Diff line 
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py

; RUN: llc < %s -mtriple=i386-pc-win32       -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq  | FileCheck %s --check-prefix=X32

; RUN: llc < %s -mtriple=x86_64-win32        -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq  | FileCheck %s --check-prefix=WIN64

; RUN: llc < %s -mtriple=x86_64-linux-gnu    -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq  | FileCheck %s --check-prefix=LINUXOSX64

; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39437.

; RUN: llc < %s -mtriple=i386-pc-win32       -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq -verify-machineinstrs=0  | FileCheck %s --check-prefix=X32

; RUN: llc < %s -mtriple=x86_64-win32        -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq -verify-machineinstrs=0  | FileCheck %s --check-prefix=WIN64

; RUN: llc < %s -mtriple=x86_64-linux-gnu    -mattr=+avx512f -mattr=+avx512vl -mattr=+avx512bw -mattr=+avx512dq -verify-machineinstrs=0  | FileCheck %s --check-prefix=LINUXOSX64



; Test regcall when receiving/returning i1

define x86_regcallcc i1 @test_argReti1(i1 %a)  {

llvm/test/CodeGen/X86/icall-branch-funnel.ll

+2 −1
Original line number Diff line number Diff line 
; RUN: llc -mtriple=x86_64-unknown-linux < %s | FileCheck %s

; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.

; RUN: llc -mtriple=x86_64-unknown-linux -verify-machineinstrs=0 < %s | FileCheck %s



@g = external global i8

llvm/test/CodeGen/X86/indirect-branch-tracking.ll

+2 −1
Original line number Diff line number Diff line 
; RUN: llc -mtriple=x86_64-unknown-unknown < %s | FileCheck %s --check-prefix=ALL --check-prefix=X86_64

; RUN: llc -mtriple=i386-unknown-unknown < %s | FileCheck %s --check-prefix=ALL --check-prefix=X86

; RUN: llc -mtriple i386-windows-gnu -exception-model sjlj < %s | FileCheck %s --check-prefix=SJLJ

; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39439.

; RUN: llc -mtriple i386-windows-gnu -exception-model sjlj -verify-machineinstrs=0 < %s | FileCheck %s --check-prefix=SJLJ



;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;; Test1

llvm/test/CodeGen/X86/pr38795.ll

+2 −1
Original line number Diff line number Diff line 
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py

; RUN: llc %s -O2 -mtriple=i386-unknown-linux-gnu -o - | FileCheck %s

; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39440.

; RUN: llc %s -O2 -mtriple=i386-unknown-linux-gnu -o - -verify-machineinstrs=0 | FileCheck %s

@.str = external dso_local unnamed_addr constant [6 x i8], align 1

@a = external dso_local local_unnamed_addr global i32, align 4

@h = external dso_local local_unnamed_addr global i32, align 4