Commit 3f944a8b authored by Raphael Isemann's avatar Raphael Isemann
Browse files

[lldb][NFC] Make name parameter in AddMethodToCXXRecordType a StringRef

parent 6aca3e8d

lldb/include/lldb/Symbol/ClangASTContext.h

+5 −7
Original line number Diff line number Diff line
@@ -768,13 +768,11 @@ public: 
                                                 const CompilerType &var_type,

                                                 lldb::AccessType access);



  clang::CXXMethodDecl *

  AddMethodToCXXRecordType(lldb::opaque_compiler_type_t type, const char *name,

                           const char *mangled_name,

                           const CompilerType &method_type,

                           lldb::AccessType access, bool is_virtual,

                           bool is_static, bool is_inline, bool is_explicit,

                           bool is_attr_used, bool is_artificial);

  clang::CXXMethodDecl *AddMethodToCXXRecordType(

      lldb::opaque_compiler_type_t type, llvm::StringRef name,

      const char *mangled_name, const CompilerType &method_type,

      lldb::AccessType access, bool is_virtual, bool is_static, bool is_inline,

      bool is_explicit, bool is_attr_used, bool is_artificial);



  void AddMethodOverridesForCXXRecordType(lldb::opaque_compiler_type_t type);

lldb/source/Symbol/ClangASTContext.cpp

+6 −7
Original line number Diff line number Diff line
@@ -7116,12 +7116,11 @@ clang::VarDecl *ClangASTContext::AddVariableToRecordType( 
}



clang::CXXMethodDecl *ClangASTContext::AddMethodToCXXRecordType(

    lldb::opaque_compiler_type_t type, const char *name, const char *mangled_name,

    const CompilerType &method_clang_type, lldb::AccessType access,

    bool is_virtual, bool is_static, bool is_inline, bool is_explicit,

    bool is_attr_used, bool is_artificial) {

  if (!type || !method_clang_type.IsValid() || name == nullptr ||

      name[0] == '\0')

    lldb::opaque_compiler_type_t type, llvm::StringRef name,

    const char *mangled_name, const CompilerType &method_clang_type,

    lldb::AccessType access, bool is_virtual, bool is_static, bool is_inline,

    bool is_explicit, bool is_attr_used, bool is_artificial) {

  if (!type || !method_clang_type.IsValid() || name.empty())

    return nullptr;



  clang::QualType record_qual_type(GetCanonicalQualType(type));
@@ -7162,7 +7161,7 @@ clang::CXXMethodDecl *ClangASTContext::AddMethodToCXXRecordType( 
      nullptr /*expr*/, is_explicit

                            ? clang::ExplicitSpecKind::ResolvedTrue

                            : clang::ExplicitSpecKind::ResolvedFalse);

  if (name[0] == '~') {

  if (name.startswith("~")) {

    cxx_dtor_decl = clang::CXXDestructorDecl::Create(

        getASTContext(), cxx_record_decl, clang::SourceLocation(),

        clang::DeclarationNameInfo(