Commit 324fd590 authored by Nicolas Vasilache's avatar Nicolas Vasilache
Browse files

[mlir][Linalg] NFC - Rename ViewTraits -> StructuredOpTraits 

Summary: This is part of an ongoing cleanup and uniformization work.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72079
parent afc25a43

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td

+2 −2
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ class NInputs<int args_in> : 
class NOutputs<int args_out> :

  NativeOpTrait<"linalg::NOutputs<" # !cast<string>(args_out) # ">::Impl"> {}



def ViewTraits : NativeOpTrait<"linalg::ViewTraits">;

def StructuredOpTraits : NativeOpTrait<"linalg::StructuredOpTraits">;



// The linalg 'LinalgStructuredInterface' provides access to the 'LinalgOp'

// interface.
@@ -147,7 +147,7 @@ def LinalgStructuredInterface : OpInterface<"LinalgOp"> { 
// depending on the specific Linalg op.

class LinalgStructuredBase_Op<string mnemonic, list<OpTrait> props>

  : Op<Linalg_Dialect, mnemonic,

       !listconcat(props, [ViewTraits, LinalgStructuredInterface])> {

       !listconcat(props, [StructuredOpTraits, LinalgStructuredInterface])> {

  let parser = [{ return parseLinalgStructuredOp(parser, result); }];

  let printer = [{ printLinalgStructuredOp(p, *this); }];

}

mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h

+2 −1
Original line number Diff line number Diff line
@@ -55,7 +55,8 @@ public: 
///   class DotOp : public Op<DotOp, OpTrait::ViewTrait> {

///

template <typename ConcreteType>

class ViewTraits : public OpTrait::TraitBase<ConcreteType, ViewTraits> {

class StructuredOpTraits

    : public OpTrait::TraitBase<ConcreteType, StructuredOpTraits> {

private:

  /// Return the number of input views. For internal use only.

  unsigned nInputs() {