Commit 267cc329 authored by Michal Gorny's avatar Michal Gorny Committed by Pavel Labath
Browse files

[lldb] [Python] Do not attempt to flush() a read-only fd 

Summary:
When creating a FileSP object, do not flush() the underlying file unless
it is open for writing.  Attempting to flush() a read-only fd results
in EBADF on NetBSD.

Reviewers: lawrence_danna, labath, krytarowski

Reviewed By: lawrence_danna, labath

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D69320
parent ec66603a

lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

+7 −5
Original line number Diff line number Diff line
@@ -1385,11 +1385,13 @@ llvm::Expected<FileSP> PythonFile::ConvertToFile(bool borrowed) { 
  if (!options)

    return options.takeError();



  if (options.get() & File::eOpenOptionWrite) {

    // LLDB and python will not share I/O buffers.  We should probably

    // flush the python buffers now.

    auto r = CallMethod("flush");

    if (!r)

      return r.takeError();

  }



  FileSP file_sp;

  if (borrowed) {